Re: [CODE] Scan snippet

From: George (greerga@CIRCLEMUD.ORG)
Date: 04/27/98


On Mon, 27 Apr 1998, Mark Gerritsen wrote:

>  if (IS_AFFECTED(ch, AFF_BLIND)) {
>    act("You can't see anything, you're blind!", TRUE, ch, 0, 0, TO_CHAR);
>    return;
>  }

AFF_FLAGGED is preferred.

>  if ((GET_MOVE(ch) < 3) && (GET_LEVEL(ch) < LVL_IMMORT)) {
>    act("You are too exhausted.", TRUE, ch, 0, 0, TO_CHAR);
>    return;
>  }

You should use 'send_to_char' for simple strings such as that.

>  maxdis = (1 + ((GET_SKILL(ch, SKILL_SCAN) * 5) / 100));
>  if (GET_LEVEL(ch) >= LVL_IMMORT)
>    maxdis = 7;

Might as well not calculate it if you're just going to assign it again
later for immortals.

>  act("You quickly scan the area and see:", TRUE, ch, 0, 0, TO_CHAR);

Better to use send_to_char() for simple strings.

>  act("$n quickly scans the area.", FALSE, ch, 0, 0, TO_ROOM);
>  if (GET_LEVEL(ch) < LVL_IMMORT)
>    GET_MOVE(ch) -= 3;
>
>  is_in = ch->in_room;
>  for (dir = 0; dir < NUM_OF_DIRS; dir++) {
>    ch->in_room = is_in;

I don't see a real use for the 'is_in' variable in there.

--
George Greer  -  Me@Null.net   | Genius may have its limitations, but stupidity
http://www.van.ml.org/~greerga | is not thus handicapped. -- Elbert Hubbard


     +------------------------------------------------------------+
     | Ensure that you have read the CircleMUD Mailing List FAQ:  |
     | http://democracy.queensu.ca/~fletcher/Circle/list-faq.html |
     +------------------------------------------------------------+



This archive was generated by hypermail 2b30 : 12/15/00 PST