Re: [bpl14] Mob Multi Attack

From: Sean Daley (sdaley@BBNPLANET.COM)
Date: 09/17/98


Two questions for you,

1) If this code works, why are you showing it to us?  If it's
   your mob code that's broke, let's see what that looks like
   so that we can help you with it.

2) Unless there's an apr++ or you set it to 1 in the beginning,
   PC's are only getting 5 attacks max, but also why are you
   doing a MAX(-1 ...?  Not a major point, but chars SHOULD
   be getting a minimum of one attack right? so why not
   apr = MAX(1, MIN(apr, 6)); ... though now that i've really
   looked at what you did, apr = 0 would be one hit since
   you check for apr >= 0, so maybe then you'd want to do a
   apr = MAX(0, MIN(apr, 5)); or else if apr starts off as 6
   people will be getting 7 attacks, apr = 5 is 6 attacks, etc.

Well, either way, it looks like the logic is a little screwy
here.

Sean

>
>if (GET_SKILL(ch, SKILL_SECOND_ATTACK) >= number(1, 101)) {
>    if (GET_SKILL(ch, SKILL_THIRD_ATTACK) >= number(1, 201)) apr++;
> if (GET_SKILL(ch, SKILL_FOURTH_ATTACK) >= number(1, 301)) apr++;
> if (GET_SKILL(ch, SKILL_FIFTH_ATTACK) >= number(1, 401)) apr++;
> if (GET_SKILL(ch, SKILL_SIXTH_ATTACK) >= number(1, 501)) apr++;
>     apr++;
>     }
>apr = MAX(-1, MIN(apr, 6));
>
>     if (apr >= 0) {
>       for (; apr >= 0 && FIGHTING(ch); apr--)
>     hit(ch, FIGHTING(ch), TYPE_UNDEFINED);


     +------------------------------------------------------------+
     | Ensure that you have read the CircleMUD Mailing List FAQ:  |
     | http://democracy.queensu.ca/~fletcher/Circle/list-faq.html |
     +------------------------------------------------------------+



This archive was generated by hypermail 2b30 : 12/15/00 PST