----- Original Message ----- From: "George Greer" <greerga@CIRCLEMUD.ORG> > On Fri, 27 Jul 2001, Mike Breuer wrote: > >Another (minor) thing I noticed recently, is just a silly thing in mag_affects > >(magic.c). The to_vict message and to_room message are sent to act like this: > > > >act(to_vict, FALSE, victim, 0, ch, TO_CHAR); > >act(to_room, TRUE, victim, 0, ch, TO_ROOM); > > > >instead of: > > > >act(to_vict, FALSE, ch, 0, victim, TO_VICT); > >act(to_room, TRUE, ch, 0, victim, TO_NOTVICT); > > A little funny. I'll take a look and see how it compares to the others. There are two implications with this that probably make it not worth the bother. Just to be clear, think of ch and victim as the variables that are used in perform_act in the following explanation. First, hide_invisible is based on ch, and not on victim when TO_NOTVICT is passed. Second, TO_NOTVICT omits both ch and victim as recipients of the message (as opposed to just the victim), which means the caster would no longer see TO_ROOM messages. These things are simple enough to fix in perform_act, but all of the code that depends on the existing behavior would have to be checked. As I said, I'm not sure it's worth the bother for an issue of semantics. Mike -- +---------------------------------------------------------------+ | FAQ: http://qsilver.queensu.ca/~fletchra/Circle/list-faq.html | | Archives: http://post.queensu.ca/listserv/wwwarch/circle.html | +---------------------------------------------------------------+
This archive was generated by hypermail 2b30 : 12/06/01 PST