Re: Nitpick

From: George (greerga@CIRCLEMUD.ORG)
Date: 03/14/98


On Sat, 7 Mar 1998, Daniel Koepke wrote:

>Little nit-pick from stock bpl12, line 351-352 of act.offensive.c, the
>do_rescue command,
>
>  if (GET_CLASS(ch) != CLASS_WARRIOR)
>    send_to_char("But only true warriors can do this!", ch);
>
>it'd probably be desirable to give the character a carriage return and
>newline sequence at the end of that...
>
>    send_to_char("But only true warriors can do this!\r\n", ch);

Fixed.

>Of course, that's the least of do_rescue()'s problems.  It's one of the
>few remnants of spaghetti code in CircleMUD (albeit it's still readable
>and rather minor compared to stuff you'll find in the original DIKU code
>[anyone remember do_stat or do_cast?]), and I'm under the impression that
>you should check if the person can even do the skill before you interpret
>the arguments...

I've saved it in my 'bugs' folder and will look at it sometime soon...

--
George Greer  -  Me@Null.net   | Genius may have its limitations, but stupidity
http://www.van.ml.org/~greerga | is not thus handicapped. -- Elbert Hubbard


     +------------------------------------------------------------+
     | Ensure that you have read the CircleMUD Mailing List FAQ:  |
     | http://democracy.queensu.ca/~fletcher/Circle/list-faq.html |
     +------------------------------------------------------------+



This archive was generated by hypermail 2b30 : 12/15/00 PST