Re: Latest DG script patch

From: Thomas Arp (t_arp@stofanet.dk)
Date: 07/12/02


From: "The Fungi" <fungi@yuggoth.org>
> This is great. I have only one question... I see no fix for my
> earlier reported bug and now I'm begining to think that maybe it
> isn't a bug but rather an intentional design feature. Room triggers
> set using redit don't show up instantly or after a zreset, but
> instead require a reboot of the MUD. Yet "attach wtr..." seems to be
> working fine immediately. Was there a specific reason to wait for a
> reboot to attach? I can easily provide a patch that fixes this but I
> thought maybe it was a bad idea for some reason I can't fathom.
>
It is fixed in pl8 - I tried hard to only let updates to bpl21 get into
that update. pl8 takes care of a number of bugs as well as adds
functionality. This is a short fix :
<semi-diff>
     return;
   }

-  /* Set script for this room */
-  world[room_num].proto_script = OLC_SCRIPT(d);
+  /* Attach Script */
+  OLC_ROOM(d)->proto_script = OLC_SCRIPT(d);
+  assign_triggers(&world[room_num], WLD_TRIGGER);

   /* Don't adjust numbers on a room update. */
   if (!new_room)
@@ -196,15 +449,13 @@ void redit_save_internally(struct descri
             OLC_ROOM(dsc)->dir_option[j]->to_room++;
     }
   }
-
-  assign_triggers(&world[room_num], WLD_TRIGGER);
 }


/*------------------------------------------------------------------------*/
</semi-diff>

> I'm also seeing what I suspect is an actual bug where attaching a
> room trigger via zedit commands appears broken...
>
>    zedit -> n -> 0 -> t -> 2 -> 4 -> q -> y -> zedit
>
> ...and the command list shows empty again. Or am I possibly not
> using it correctly?

You are. I'll be fixing this, thanks to Artovil for the nice 'walkthrough'.

Welcor

--
   +---------------------------------------------------------------+
   | FAQ: http://qsilver.queensu.ca/~fletchra/Circle/list-faq.html |
   | Archives: http://post.queensu.ca/listserv/wwwarch/circle.html |
   | Newbie List:  http://groups.yahoo.com/group/circle-newbies/   |
   +---------------------------------------------------------------+



This archive was generated by hypermail 2b30 : 06/25/03 PDT