Re: Patch/Snippet Resolution

From: d. hall (dhall@OOI.NET)
Date: 09/03/98

>>>>>> thus on Thu, 3 Sep 1998 12:26:34 -0400, Del wrote:

> If src was for source files, I guess thats the reason we have the TODO and
> the Changelog in there.. (and what ever else files in there) What about all
> those .README's that people include in the patches that get created..

Those apply the source files.

> There is absolutely NOTHING wrong with placing the credits file in this
> directory as you can easily note WHO wrote which parts of the "source code".
> Kind of like the top 5-10 lines of every src file.

Okay, let's get pedantic.

We'll have to move the motd and imotd to the src/, since they can be
changed as well.  And we'll have to move the title banners to src/ as well.
While we're at it, we should move all the world, zone and shop files, since
those might need patching.

The lib files are read at run time into the mud server, as well as the
credit files, that is why they are in src/.  Run time dynamic text files
are kept in one place for a reason, if you're trying to argue to keep
things simple, at least keep things consistant.

Changelog isn't read by the mud.  README isn't read by the mud.  COPYING
isn't read by the mud, need I go on?

I will say it again, there is _nothing_ preventing you from 'cd ..' up one
directory to apply the patch.  It's a common practice to apply patches to
the whole distribution, and not just the src/.

> We can probably argue on the concept of which files belong in the src
> directory and which belong in the lib directory for days.. My point is,
> to eliminate confusion, not having to move up a higher directory to
> include ONE file, and people's forgetfulness..

It's very easy to write a blurb at the top of the patch file that says, cd
in such and such directory and do such and such.  Most people have to chop
off two directories from the head of the patch file to get it to apply.

> Move the credits file to SRC directory. If the patch fails on the Credits
> file.. its Much easier to copy and paste the line that got rej'd and move
> on.. than it is to change directories, figure out the name (and email if
> need be) of the coder, add it to the credits, change directories back to
> src and continue..

This does _not_ solve the 'problem' already listed, which numerous people
have attempted to explain over and over.  Several patches applied to the
same file will not patch in a consistant manner.


     | Ensure that you have read the CircleMUD Mailing List FAQ:  |
     | |

This archive was generated by hypermail 2b30 : 12/15/00 PST