Re: [CODE] Questions about macros

From: Carlos Myers (
Date: 03/28/01

>From: George Greer <greerga@CIRCLEMUD.ORG>
>On Wed, 28 Mar 2001, Carlos Myers wrote:
> >1. Why wasn't George Greer's IN_ROOM patch included in the latest patch
> >level?
>My what? I seem to have forgotten what that is.

My bad, it was Geoff Davis.

> >3. GET_OBJ_NUM(obj) in shop.h and GET_OBJ_RNUM(obj) in util.h are defined
> >the same, however, GET_OBJ_NUM(obj) is not used anywhere.  Is it there
> >compatibility with older patches to the shops or should it something that
> >needs to be removed?
>I think I already removed that one...[checks]  Yep, it's already gone, just
>not committed.

Does that mean that GET_OBJ_NUM will be gone by patchlevel 19?  I'm assuming
that "not committed" has something to do with cvs.

> >5. CAN_WEAR(obj, part) and OBJWEAR_FLAGGED(obj, flag) are also defined as
> >the same.  Any particular reason why one should be used over the other?
>I'd use OBJWEAR_FLAGGED because CAN_WEAR sounds like it should take a 'ch'

Seems like you may want to do a mass replace then as I believe that
OBJWEAR_FLAGGED is used only once, where as CAN_WEAR is all over the place.

> >Overall, I think there is need for a general clean up of the macros in
> >util.h.  It may even be time to declare some the macros, such as
> >GET_OBJ_NUM(obj) and OBJWEAR_FLAGGED(obj, flag), as decrepit.
>I generally just yank them in a few patchlevels.  If someone patches up (by
>hand, right?), then they should notice.  I'll keep stuff around that is
>Circle 2.x compatibility cruft but anything else will go.

I was wondering if there was a system of clearing out deprecated macros.
Now I know. :)

BTW, do you go through a similar procedure with unused external variables?
I do recall a few, but I am tending to think they may have been OasisOLC
v2.0 artifacts.


Get your FREE download of MSN Explorer at

   | FAQ: |
   | Archives: |

This archive was generated by hypermail 2b30 : 12/04/01 PST