Re: containers bug

From: Wout Mertens (Wout.Mertens@rug.ac.be)
Date: 04/14/96


On Sat, 13 Apr 1996, Sammy wrote:

> I dug this out of my saved mail.

> From: Webmaster <anderson@nol.net>
> Subject: Bugfix for generic_find()
> 
[...]
> the line that reads
> 
> if ( GET_EQ(ch, i) && isname(name, GET_EQ(ch, i)->name) == 0 )
> 
> should have the 0 exchanged for a 1 to read
> 
> if ( GET_EQ(ch, i) && isname(name, GET_EQ(ch, i)->name) == 1 )

Sorry, but I just had to say this: the second part of the if is
a) ugly
b) bad coding

because isname is definitely a function that should return a bool, being 
0 or non-zero (not 1; -1 is also non-zero... see?) and isname==1 is just 
weird to read

Suggest you change it to (... && isname(..) )

Gekke Eekhoorn of BUG.



This archive was generated by hypermail 2b30 : 12/18/00 PST